ivanallen commented on code in PR #3196:
URL: https://github.com/apache/brpc/pull/3196#discussion_r2739434391
##########
example/benchmark_fb/test.fbs:
##########
@@ -0,0 +1,24 @@
+namespace test;
+
+table BenchmarkRequest {
+ opcode:int;
+ echo_attachment:int;
+ attachment_size:long;
+ request_id:long;
+
+ reserved:long;
+ message:string;
+}
+
+table BenchmarkResponse {
+ opcode:int;
+ echo_attachment:int;
+ attachment_size:long;
+ request_id:long;
+ reserved:long;
+ message:string;
+}
+
+rpc_service BenchmarkService {
Review Comment:
fb 是否可以给这样使用，显式的在 method 后指定 index？
对于从中间删除 method 会导致不兼容的情况，感觉是个隐患，用户不太容易注意到。
```
rpc_service BenchmarkService {
Test1(BenchmarkRequest):BenchmarkResponse = 1;
Test2(BenchmarkRequest):BenchmarkResponse = 2;
}
```
##########
example/benchmark_fb/test.fbs:
##########
@@ -0,0 +1,24 @@
+namespace test;
+
+table BenchmarkRequest {
+ opcode:int;
+ echo_attachment:int;
+ attachment_size:long;
+ request_id:long;
+
+ reserved:long;
+ message:string;
+}
+
+table BenchmarkResponse {
+ opcode:int;
+ echo_attachment:int;
+ attachment_size:long;
+ request_id:long;
+ reserved:long;
+ message:string;
+}
+
+rpc_service BenchmarkService {
Review Comment:
fb 是否可以这样使用，显式的在 method 后指定 index？
对于从中间删除 method 会导致不兼容的情况，感觉是个隐患，用户不太容易注意到。
```
rpc_service BenchmarkService {
Test1(BenchmarkRequest):BenchmarkResponse = 1;
Test2(BenchmarkRequest):BenchmarkResponse = 2;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
