wwbmmm commented on PR #3244: URL: https://github.com/apache/brpc/pull/3244#issuecomment-4159789557
I think the current approach is too complex for maintaining, and it increase the computational cost: `release_tls_block` from O(1) to O(N), `release_tls_block_chain` from O(M) to O(M*N). where N is the existing tls block number, M is the existing block number in the block_chain. Why will this happen: "double release_tls_block() of the same block" ? This may indicate bugs in the upper-layer code. I suggest you to dig into this to find the root-cause, other than work around in the `release_tls_block` code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
