rajvarun77 commented on PR #3310: URL: https://github.com/apache/brpc/pull/3310#issuecomment-4557134364
Update — pushed `38a01f33` (force-push, rebased on master at `477fa492`). **Two changes since the last comment:** 1. **TLS shortcut for `caching_sha2_password` slow path is now supported.** Added `CachingSha2PasswordCleartext()` + a dispatcher `CachingSha2PasswordSlowPath(password, salt, server_pubkey_pem, bool is_ssl = false)`. Default `is_ssl=false` preserves the existing RSA-OAEP behavior; callers that have confirmed the channel is secure pass `is_ssl=true` and skip the 3-round-trip RSA path. The codec layer stays pure-functional — Stage-1c's Socket integration just threads `Socket::is_ssl()` straight into the trailing argument. Full rationale + the libmysqlclient reference (`sql-common/client_authentication.cc:770-787`) is in the PR description under "TLS shortcut via `is_ssl` flag". 2. **Test count: 75** (+11 from the previous push) — 5 new in `MysqlCachingSha2CleartextTest` + 6 new in `MysqlCachingSha2SlowPathTest`. PR description has the by-name mapping table to all 28 upstream unit tests in `mysql/mysql-server` plus the 6 client-relevant MariaDB integration tests (deferred). **Asks:** - @wwbmmm @chenBright @yanglimingcn — could you click *Approve and run* on the Checks tab? The previous 17-job suite all passed on `bc95c031`; the new commit is gated on the outside-contributor approval workflow. - Still open: the integration-test approach question from the previous comment (redis-style `system()`-spawn of `mysqld` vs. Docker vs. mtr — whichever pattern you prefer). PR ready for first-pass review whenever you have bandwidth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
