Felix-Gong opened a new pull request, #3316: URL: https://github.com/apache/brpc/pull/3316
## Summary - Fix crash when HTTPS pooled connection encounters unexpected SSL EOF (error_code=0) - Properly handle SSL_ERROR_SSL in socket.cpp DoRead() to return ESSL instead of 0 - Discovered during RISC-V porting and integration testing ## Root Cause When OpenSSL 3.x detects unexpected EOF (peer closed without close_notify), SSL_read returns 0 with SSL_ERROR_SSL. The code didn't return -1, causing error_code=0 to propagate to Controller::SetFailed() which triggers CHECK(false). ## Fix In the default branch of DoRead(), return -1 with errno=ESSL when SSL errors are detected, instead of falling through and returning nr. Fixes #3307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
