Felix-Gong commented on PR #3316: URL: https://github.com/apache/brpc/pull/3316#issuecomment-4598289589
> I think you should add the unit test `ssl_unexpected_eof` to this PR, rather than creating a new PR. I'd prefer to keep the test in a separate PR (#3321) because the fix and the test are independent changes. This way the fix can be reviewed and merged first, and the test PR can be rebased to verify CI passes. If you think it's better to combine them, I can merge them into one PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
