Felix-Gong commented on PR #3346: URL: https://github.com/apache/brpc/pull/3346#issuecomment-4703714175
Good point! `-fno-access-control` is indeed a cleaner approach than `#define private public`. It avoids the redeclaration issues with standard library headers entirely. I'll update the PR to: 1. Replace `-Dprivate=public` with `-fno-access-control` in CMake build flags 2. Simplify `sstream_workaround.h` (the `#ifdef private` guard becomes unnecessary) The Bazel build already uses `-fno-access-control` at [test/BUILD.bazel:26](https://github.com/apache/brpc/blob/172589604ffbb5c970b9bcd3c1df0441a9614dd6/test/BUILD.bazel#L26), so this makes CMake consistent with Bazel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
