chenBright commented on code in PR #3328: URL: https://github.com/apache/brpc/pull/3328#discussion_r3369162834
########## src/bthread/types.h: ########## @@ -152,7 +152,14 @@ static const size_t BTHREAD_EPOLL_THREAD_NUM = 1; static const bthread_t BTHREAD_ATOMIC_INIT = 0; // Min/Max number of work pthreads. +// When RDMA or io_uring is compiled in, their dedicated Poller threads handle +// I/O directly, so the bare minimum drops to 1 worker + epoll thread. +// Otherwise keep the traditional floor of 3 + epoll (1 epoll + 2 workers). +#if defined(BRPC_WITH_RDMA) || defined(BRPC_WITH_IOURING) +static const int BTHREAD_MIN_CONCURRENCY = 1 + BTHREAD_EPOLL_THREAD_NUM; +#else static const int BTHREAD_MIN_CONCURRENCY = 3 + BTHREAD_EPOLL_THREAD_NUM; +#endif Review Comment: @yanglimingcn This issue deserves attention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
