wwbmmm opened a new pull request, #3354:
URL: https://github.com/apache/brpc/pull/3354
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
The Redis command parser accepted an empty RESP array as the start of a
command
and kept parsing subsequent bulk strings as array elements. Since an empty
array
has no command name or arguments, this input should be rejected by the
parser.
### What is changed and the side effects?
Changed:
- Reject empty RESP command arrays in `RedisCommandParser`.
- Replace the internal array index `CHECK` with an explicit parse error
before
writing parsed bulk strings into the argument vector.
- Add a parser regression test for empty RESP arrays followed by bulk
strings.
Side effects:
- Performance effects: None expected.
- Breaking backward compatibility: Empty RESP arrays are now rejected as
invalid
Redis commands.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
