rajvarun77 commented on PR #3330: URL: https://github.com/apache/brpc/pull/3330#issuecomment-4900248768
@chenBright — checking in on the path to merge here. It has been three weeks since the handoff to @yanglimingcn (Jun 16) with no activity, and the PR has been merge-ready throughout: 15/15 CI lanes green, all review threads resolved (your `ResetPods`/`bind_sock_action` comment addressed in `530e1124`), and @wwbmmm's LGTM. Would @wwbmmm's approval be sufficient to merge, or is @yanglimingcn's review a hard requirement? @yanglimingcn — happy to walk through any part of the implementation (clean-room auth handshake, prepared-statement/transaction connection affinity, binary protocol) if that would make the review easier. And if you don't have bandwidth right now, no problem at all — just let us know how you'd like to proceed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
