rajvarun77 commented on PR #3367: URL: https://github.com/apache/brpc/pull/3367#issuecomment-4920434270
@chenBright thanks for the review — all four comments are addressed in the latest commit: choices/tau defaults are now gflags, error punishment is capped by `p2c_max_punish_ms` so recovery is bounded, the FlatMap init is removed, and lock-overhead numbers are in the thread (265 ns/op uncontended, ~700 ns/op worst case). CI is green — PTAL, and happy to iterate further. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
