lo-tk commented on code in PR #3386:
URL: https://github.com/apache/brpc/pull/3386#discussion_r3585617968
##########
src/brpc/stream.cpp:
##########
@@ -672,7 +672,7 @@ int Stream::SetHostSocket(Socket *host_socket) {
}
_host_socket = ptr.release();
});
- return 0;
+ return _host_socket != NULL ? 0 : -1;
Review Comment:
这个-1返回值不是新引入的，以前就会返回-1，只是后来被去掉了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
