ubeddulla commented on PR #3387: URL: https://github.com/apache/brpc/pull/3387#issuecomment-4979210684
Pushed an update covering the review: - Gated the CR/LF check behind `-http_check_outbound_header_crlf` (default on) so it can be turned off on hot paths that never forward untrusted header values. - Changed the skip logs from ERROR to WARNING, and run the header name through `butil::ToPrintable` so a CR/LF in the name can't inject newlines into the log. - Content-Type now logs the same warning when skipped instead of dropping silently, in both request and response paths. - Added an explicit Content-Type CR/LF test for request and response, each with its own IOBuf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
