wasphin commented on code in PR #3458:
URL: https://github.com/apache/brpc/pull/3458#discussion_r3800098594
##########
src/brpc/policy/mysql/mysql_auth_packet.cpp:
##########
@@ -43,7 +43,7 @@ size_t DecodeLengthEncodedInt(const butil::StringPiece& buf,
uint64_t* out,
return 1;
}
if (first == 0xfb) {
- // 0xFB is the lenenc NULL marker, not a length prefix. Report NULL
+ // 0xFB is the lenenc nullptr marker, not a length prefix. Report
nullptr
Review Comment:
Some `NULL`s in the comments are protocol-level terms, not C++
null pointers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
