darion-yaphet commented on code in PR #3433:
URL: https://github.com/apache/brpc/pull/3433#discussion_r3850636033
##########
test/brpc_channel_unittest.cpp:
##########
@@ -2316,6 +2316,46 @@ TEST_F(ChannelTest, init_as_single_server) {
}
}
+TEST_F(ChannelTest, reject_reinitialization_after_successful_init) {
+ butil::EndPoint first_endpoint;
+ butil::EndPoint second_endpoint;
+ ASSERT_EQ(0, str2endpoint("127.0.0.1:59347", &first_endpoint));
+ ASSERT_EQ(0, str2endpoint("127.0.0.1:59348", &second_endpoint));
+
+ {
+ brpc::Channel channel;
+ ASSERT_EQ(0, channel.Init(first_endpoint, NULL));
+ ASSERT_EQ(-1, channel.Init(first_endpoint, NULL));
+ ASSERT_EQ(-1, channel.Init(second_endpoint, NULL));
+ ASSERT_EQ(-1, channel.Init("unknown://unknown", "rr", NULL));
+ }
Review Comment:
The code and test had already switched to rejecting reinitialization after a
successful Init(), but the GitHub PR description was not updated accordingly,
which caused the inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
