zchuango commented on code in PR #3495: URL: https://github.com/apache/brpc/pull/3495#discussion_r3877336243
########## src/bthread/context.cpp: ########## @@ -347,20 +347,40 @@ __asm ( " pushq %r14 \n" " pushq %r13 \n" " pushq %r12 \n" -" leaq -0x8(%rsp), %rsp\n" +" leaq -0xa8(%rsp), %rsp\n" +" movups %xmm6, 0x00(%rsp)\n" +" movups %xmm7, 0x10(%rsp)\n" +" movups %xmm8, 0x20(%rsp)\n" +" movups %xmm9, 0x30(%rsp)\n" Review Comment: Added bthread_context_unittest.cpp to verify that XMM6-XMM15 values round-trip correctly across bthread_jump_fcontext. The updated Linux CI, including Clang/GCC unit tests and Clang ASan, passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
