wasphin opened a new pull request, #3501:
URL: https://github.com/apache/brpc/pull/3501
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
`DHWrapper::copy_shared_key` only released the temporary peer public key
when `DH_compute_key` failed. Successful RTMP complex handshakes retained the
allocation.
### What is changed and the side effects?
Changed:
Release the temporary peer public key immediately after `DH_compute_key`
returns, covering both success and failure paths.
Side effects:
- Performance effects: Negligible; this only releases an allocation when its
last use completes.
- Breaking backward compatibility: No.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
