walterzhaoJR commented on PR #3417: URL: https://github.com/apache/brpc/pull/3417#issuecomment-5505373046
Thanks for the clarification and for providing the fix in #3470. We agree that running user callbacks outside the global VarMap lock, while protecting object lifetime through `ExposedRef`, is a safer solution and avoids introducing a circular dependency between bvar and the bthread scheduler. We will apply/backport the #3470 fix in our own environment and validate it against our workload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
