chenBright commented on code in PR #3512:
URL: https://github.com/apache/brpc/pull/3512#discussion_r3913946336
##########
src/brpc/policy/http2_rpc_protocol.cpp:
##########
@@ -1373,6 +1273,14 @@ int
H2StreamContext::ConsumeHeaders(butil::IOBufBytesIterator& it) {
case 'p':
if (strcmp(name + 2, /*p*/"ath") == 0) {
matched = true;
+ // RFC 9113 8.3.1: :path MUST NOT be empty and, apart from
+ // the asterisk-form that OPTIONS may use, MUST begin with
+ // '/'.
+ if (pair.value != "*" &&
Review Comment:
No, :method may not have arrived.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
