wasphin opened a new pull request, #3531:
URL: https://github.com/apache/brpc/pull/3531

   ### What problem does this PR solve?
   
   Issue Number: resolve
   
   Problem Summary:
   
   `StreamingRpcTest.limit_streams_accepted_per_request` can hang while joining
   the server. The service discards the response stream identifiers returned by
   `StreamAccept`, so cleanup depends on the timing of close frames from the
   client side.
   
   ### What is changed and the side effects?
   
   Changed:
   
   - Keep the accepted response stream identifiers in the test service.
   - Explicitly close both response and request streams after each request.
   
   Side effects:
   - Performance effects: None.
   
   - Breaking backward compatibility: No. This only fixes unit-test cleanup.
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to