rajvarun77 commented on PR #3526: URL: https://github.com/apache/brpc/pull/3526#issuecomment-5594843114
Addressed the two points from the latest Copilot pass in 66127fc4: - Warm-up diversion can no longer produce EHOSTDOWN. In rr, random, wrr and consistent hashing, a server skipped by the ramp was dropped for the rest of the `SelectServer` call, so if every remaining server was down the call failed although the warming server was available. Each policy now runs a second pass with the ramp disabled when the first pass skipped a warming server and found nothing else. Regression test: `cold_server_still_selected_when_others_down` (warm server `SetFailed`, cold server up, 1000/1000 selections must succeed) across all four policies. - `<algorithm>` included directly in load_balancer.cpp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
