darion-yaphet opened a new pull request, #3534:
URL: https://github.com/apache/brpc/pull/3534
### What problem does this PR solve?
Problem Summary:
Replace internal uses of legacy `butil` integer-to-string helpers with
`std::to_string` to reduce duplicated conversion logic.
### What is changed and the side effects?
Changed:
- Use `std::to_string` for internal `IntToString` and `UintToString` call
sites.
- Keep the public `butil::IntToString(int)` and
`butil::UintToString(unsigned)` APIs as compatibility wrappers backed by
`std::to_string`.
- Update integer conversion tests while preserving unsigned conversion
behavior for negative `int` inputs.
Side effects:
- Performance effects: No benchmark was run; no expected material impact.
- Breaking backward compatibility: No. The existing public helper APIs
remain available.
---
### Check List:
- [x] Please make sure your changes are compilable.
- `cmake --build build --target BUTIL_LIB -j6`
- `cmake --build build --target test_butil -j6`
- [x] Related tests updated and passed.
- `StringNumberConversionsTest.IntToString`
- `HttpTest.http_head`
- [x] Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
