wasphin opened a new pull request, #3564: URL: https://github.com/apache/brpc/pull/3564
### What problem does this PR solve? Issue Number: N/A Problem Summary: The backup request policy test used a fatal assertion while waiting for short connections to close. On a slow CI runner, the assertion could return from the helper before `StopAndJoin()`, leaving the acceptor active while later parameter combinations continued to run. ### What is changed and the side effects? Changed: Record a connection-close timeout, stop and join the acceptor, and then report the failure. Allow up to one second for asynchronous short-connection cleanup so the test does not enforce a 100 ms timing assumption unrelated to backup request policy behavior. Side effects: - Performance effects: Test-only change; no production performance impact. - Breaking backward compatibility: No. --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
