darion-yaphet opened a new pull request, #3565:
URL: https://github.com/apache/brpc/pull/3565
### What problem does this PR Solve?
Issue Number: resolve N/A
Problem Summary:
The `CMakeLists.txt` of `example/auto_concurrency_limiter` was copied from
`example/asynchronous_echo_c++` when the example was first added (commit
`75cfdf6a`, 2018), but the project name and target names were never renamed. As
a result:
- The project is declared as `asynchronous_echo_c++`, conflicting with the
real `asynchronous_echo_c++` example (e.g. if examples are ever aggregated via
`add_subdirectory`).
- The built binaries are named `asynchronous_echo_client` /
`asynchronous_echo_server`, which misleads users looking for the auto
concurrency limiter example binaries.
- This directory has no Makefile, so CMake is the only build path and every
user hitting this example gets the wrong names.
### What is changed and the side effects?
Changed:
- `exampleCMakeLists.txt`:
- `project(asynchronous_echo_c++)` → `project(auto_concurrency_limiter)`
- Targets `asynchronous_echo_client` / `asynchronous_echo_server` →
`cl_client` / `cl_server` (matching the `cl_` prefix of `cl_test.proto`)
Verified by a full CMake configure + build against the in-tree `output/`
artifacts, producing `auto_concurrency_limiter_client` and
`auto_concurrency_limiter_server` successfully.
Side effects:
- Performance effects: None
- Breaking backward compatibility: No. Only example target/binary names
change; the library is untouched.
---
### Check List:
- Please make sure your changes are compilable. ✅ (verified with a full
local build)
- When providing us with a new feature, it is best to add related tests.
(N/A — example build fix)
- Please follow . ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
