two-headBoy opened a new pull request, #3566:
URL: https://github.com/apache/brpc/pull/3566

   ### What problem does this PR solve?
   
   Issue Number: resolve #2275
   
   Problem Summary:
   An empty value passed as a `%b`/`%s` argument was silently dropped, 
producing a Redis command with the wrong number of arguments and causing "wrong 
number of arguments" errors.
   
   ### What is changed and the side effects?
   
   Changed:
   - Empty `%b`/`%s` arguments now emit an empty bulk string instead of being 
dropped.
   - `%s` with NULL, and `%b` with NULL and non-zero size, return an error to 
avoid undefined behavior.
   - Added unittests.
   
   Side effects:
   - Performance effects: none.
   
   - Breaking backward compatibility: none.
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to