AnDiXL commented on PR #3558: URL: https://github.com/apache/brpc/pull/3558#issuecomment-5845217713
Thanks for the detailed review. I will make another update for the actionable items in this PR: - Move the Make-generated FlatBuffers test header out of the source tree and include it from a generated/ignored directory, so it cannot shadow CMake output. - Add the FlatBuffers compile-time version guard and document the supported/tested version range. - State the receive-side caller contract in `message.h` and docs: bound untrusted `msg_size` before parsing, then call `Verify<T>()` before reading. - Adjust the `Message::MergeFrom` behavior so the protobuf API path does not abort the process on an ordinary copy request. - Clarify the `service.h` dispatch contract. Yes, this is the public contract the RPC transport follow-up consumes: generated services validate method/request ownership and execute non-null completion callbacks exactly once; transport-side wire dispatch uses stable method IDs via `FindMethodByIndex()`. For the hosted FlatBuffers ON matrix, I kept it in the dependent follow-up draft #3559 instead of this smaller message/codegen PR. #3559 adds the workflow and runner and covers the FlatBuffers-enabled CMake/Make/Bazel paths together with the RPC/example changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
