alxrxs commented on PR #3569: URL: https://github.com/apache/brpc/pull/3569#issuecomment-6012104806
I've now measured this on hardware with brpc's own rdma_performance example. Setup: two hosts with Intel Xeon Platinum 8360Y and ConnectX-6 Dx (RoCEv2, 100 Gb/s), Ubuntu 24.04, kernel 6.8, rdma-core 50. Server and client each pinned to one core on the NIC's NUMA node, one thread, depth 1, echo on. Base is this PR's merge base (535d8f89), head is this PR (8e40af7f). 10 rounds per size, base and head alternating. I took the time per RPC from the client's printed throughput (attachment bytes / MB/s), because Avg-Latency is printed in whole microseconds. The sizes below are the lengths of the messages as posted. On these NICs the head inlines a message when it is 236 bytes or less. I checked that with a counting build: every send of 236 bytes or less went inline, and none above. | request / response (bytes) | inlined with this PR | base (us per RPC) | change with this PR (us), 95% interval | |---|---|---:|---:| | 64 / 38 | both | 29.03 | -1.12 [-1.31, -0.93] | | 128 / 102 | both | 29.21 | -0.98 [-1.19, -0.77] | | 200 / 174 | both | 29.33 | -1.03 [-1.15, -0.91] | | 232 / 206 | both | 29.41 | -0.99 [-1.13, -0.86] | | 241 / 215 | response only | 29.38 | -0.53 [-0.68, -0.37] | | 512 / 486 | neither | 29.73 | -0.04 [-0.19, +0.11] | | 267 / 241 | neither | 29.37 | +0.08 [-0.00, +0.16] | So when both messages are inlined, an echo RPC takes about 1 us less (about 3.5%). With only the response inlined it's about half that, and when neither message fits there's no change I can resolve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
