zchuango commented on PR #3535: URL: https://github.com/apache/brpc/pull/3535#issuecomment-6056634672
Thanks @chenBright for the detailed review! I've updated this PR to address the recent feedback, including: - Fixing the URMA transport type handling. - Fixing UBSHM handshake continuation and shared-memory name handling. - Preventing TCP application data from being parsed after a successful upgrade. - Making handshake memory ordering explicit. - Improving resource cleanup and TCP fallback handling. - Adding regression tests for handshake fragmentation, TCP fallback, and resource cleanup. I've also addressed the related style comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
