This is an automated email from the ASF dual-hosted git repository.
chenBright pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 74e2c926 fix(cmake): require all BoringSSL components (#3594)
74e2c926 is described below
commit 74e2c92654f07024d456e00e428eb5449ad5a810
Author: darion-yaphet <[email protected]>
AuthorDate: Sat Oct 10 13:59:21 2026 +0800
fix(cmake): require all BoringSSL components (#3594)
Fail during dependency discovery when WITH_BORINGSSL is enabled and
required components are missing.
Check the include directory, SSL library, and Crypto library separately to
avoid reporting success for an incomplete library list.
---
CMakeLists.txt | 2 +-
cmake/FindBoringSSL.cmake | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e98e0c4f..4d00c90b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -403,7 +403,7 @@ if(NOT PROTOC_LIB)
endif()
if(WITH_BORINGSSL)
- find_package(BoringSSL)
+ find_package(BoringSSL REQUIRED)
list(APPEND BRPC_COMMON_INCLUDE_DIRS ${BORINGSSL_INCLUDE_DIR})
else()
if(CMAKE_SYSTEM_NAME STREQUAL "Darwin" AND NOT OPENSSL_ROOT_DIR)
diff --git a/cmake/FindBoringSSL.cmake b/cmake/FindBoringSSL.cmake
index b475f0aa..fc5ec27e 100644
--- a/cmake/FindBoringSSL.cmake
+++ b/cmake/FindBoringSSL.cmake
@@ -63,8 +63,9 @@ set(BORINGSSL_LIBRARIES ${BORINGSSL_SSL_LIBRARY}
${BORINGSSL_CRYPTO_LIBRARY}
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(BoringSSL DEFAULT_MSG
- BORINGSSL_LIBRARIES
- BORINGSSL_INCLUDE_DIR)
+ BORINGSSL_INCLUDE_DIR
+ BORINGSSL_SSL_LIBRARY
+ BORINGSSL_CRYPTO_LIBRARY)
mark_as_advanced(
BORINGSSL_ROOT_DIR
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
