ehds opened a new pull request, #3617: URL: https://github.com/apache/brpc/pull/3617
### What problem does this PR solve? Issue Number: resolve Problem Summary: ### What is changed and the side effects? `MultiFlatMap::erase` destroyed the bucket-head element before moving a surviving collision node into it. Assigning to the destroyed element caused use-after-destruction: ``` malloc: *** error for object 0xa87003de0: pointer being freed was not allocated malloc: *** set a breakpoint in malloc_error_break to debug ``` Changed: Keep the bucket-head element alive when another node in the bucket survives. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
