songgaoye opened a new pull request, #3619:
URL: https://github.com/apache/brpc/pull/3619
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
`FlatMap::swap()` does not fully reset the moved-from object when swapping a
default-initialized `SparseFlatMap` with a dynamically initialized one.
After transferring the dynamic buckets to the default map, the moved-from map
resets `_buckets` but mistakenly assigns `_thumbnail` to itself. Its
thumbnail
therefore still points to the transferred dynamic storage. Once the new owner
is destroyed, later operations on the moved-from map can access freed memory.
### What is changed and the side effects?
Changed:
- Reset the moved-from map's `_thumbnail` to `_default_thumbnail` together
with `_buckets`.
- Add regression tests for swapping default and dynamic `SparseFlatMap`
instances, including use after the temporary owner is destroyed.
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
