darion-yaphet commented on PR #3558: URL: https://github.com/apache/brpc/pull/3558#issuecomment-6265928547
Nice work on this PR! I appreciate the clear scope and the care put into buffer ownership and builder lifetimes. The tests cover plenty of tricky cases and the docs make the limitations easy to understand. Thanks for putting this together! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
