darion-yaphet commented on PR #3590: URL: https://github.com/apache/brpc/pull/3590#issuecomment-6260021368
Thanks for pointing these out. I agree this PR has grown beyond its original goal of cleaning up allocations when Server::Start() fails before RUNNING. The deferred TLS key deletion and pool reference tracking introduce broader lifecycle and performance concerns. I’ll move that work into a separate PR to address factory lifetime, teardown deadlocks, and normal-path locking overhead together. I’ll rework this PR around the original startup-failure cleanup and regression tests, and verify that the reduced scope is independently safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
