ehds opened a new pull request, #3627: URL: https://github.com/apache/brpc/pull/3627
### What problem does this PR solve? Issue Number: resolve Problem Summary: Without std::move, data is passed to Init as an lvalue, In this case, the move constructor will not be called. And for move-only type, this call will not compile. ### What is changed and the side effects? Changed: std::move(data) is required to move-construct data_mem. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
