Copilot commented on code in PR #3628:
URL: https://github.com/apache/brpc/pull/3628#discussion_r4321356624
##########
.github/workflows/ci-macos.yml:
##########
@@ -29,7 +29,14 @@ jobs:
- name: install dependences
run: |
- brew install openssl gnu-getopt coreutils gflags leveldb protobuf@21
+ brew install openssl gnu-getopt coreutils gflags leveldb
+ # Homebrew disabled protobuf@21 on 2026-01-08 and removes disabled
formulae one year
+ # after that date. Install it from a local tap holding the
homebrew-core formula,
+ # pinned to a commit and without its deprecate!/disable! lines.
+ brew tap-new --no-git local/pins
+ curl -fsSL
https://raw.githubusercontent.com/Homebrew/homebrew-core/cced3ef1d489fce4eba453a333619722c3a8dd17/Formula/p/[email protected]
\
+ | grep -v -E '^[[:space:]]*(deprecate|disable)!' > "$(brew
--repository local/pins)/Formula/[email protected]"
Review Comment:
The workflow assumes the tap's `Formula/` directory already exists. To avoid
a hard failure if Homebrew changes `tap-new --no-git` behavior (or if the
directory isn't created for some reason), create the directory explicitly
(e.g., `mkdir -p \"$(brew --repository local/pins)/Formula\"`) before
redirecting the file.
##########
.github/workflows/ci-macos.yml:
##########
@@ -29,7 +29,14 @@ jobs:
- name: install dependences
Review Comment:
Spelling: rename the step from 'install dependences' to 'install
dependencies' for correct terminology and consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
