sahvx655-wq commented on PR #3622: URL: https://github.com/apache/brpc/pull/3622#issuecomment-6286014999
Picked up the remaining test nits in e300720. Both writes now go through butil::WriteFileDescriptor, which already loops on short writes and retries EINTR, and the two read() calls are wrapped in HANDLE_EINTR so a stray signal can't turn into a false failure. The EOF check keeps its meaning: a timeout is still -1 with EAGAIN and still fails the assertion, only EINTR gets retried. The /version request also carries a Host header now. brpc's HTTP parser doesn't insist on one, so this wasn't failing anywhere, but there's no reason to rely on that leniency in a regression test. None of this touches the fix in rtmp_protocol.cpp or what the test asserts, it only takes the socket plumbing out of the list of things that could flake. I couldn't rerun brpc_rtmp_unittest on the box I had to hand this time (no gflags/protobuf there), so I've only checked that the changed lines compile against the real butil headers. CI should confirm the full run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
