chenBright opened a new pull request, #3637:
URL: https://github.com/apache/brpc/pull/3637
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
On macOS, repeated `futex_wake_private()` calls can count an already
notified waiter
again before it resumes. Callers such as `TaskControl::signal_task()` may
consequently
stop notifying other parking lots prematurely, leaving idle workers asleep
while tasks
remain queued
### What is changed and the side effects?
Changed:
- Replace aggregate waiter counting with an intrusive queue of unnotified
waiters, each
owning a condition variable and notification flag.
- Remove each waiter from the queue when notified, preventing subsequent
wake calls
from counting it again.
- Remove timed-out waiters individually and retry spurious wakeups without
extending
the original deadline.
- Honor notifications that win the mutex race with a timeout.
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
