songgaoye opened a new pull request, #3640: URL: https://github.com/apache/brpc/pull/3640
### What problem does this PR solve? `ResourcePool::Block::nitem` is incremented by the owning `LocalPool` after constructing an item. Meanwhile, another thread may call `address_resource()` for an already-published resource in the same block, which reads `nitem` for bounds checking. Because `nitem` is a plain `size_t`, these concurrent reads and writes form a C++ data race. ### What is changed and the side effects? Changed: - Make `ResourcePool::Block::nitem` atomic. - Publish item-count increments with release semantics after construction. - Read `nitem` with acquire semantics in `address_resource()`. Side effects: - Performance effects: - Breaking backward compatibility: --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
