chenBright commented on PR #3639: URL: https://github.com/apache/brpc/pull/3639#issuecomment-6333998884
> LGTM. > > As a separate, non-blocking suggestion, we could consider moving benchmark-related code out of unit tests into dedicated benchmarks. Unit tests should primarily focus on correctness, while benchmarks can be run independently for performance evaluation. This would also help keep CI tests faster and more predictable. @wasphin Agree! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
