wwbmmm commented on code in PR #3615:
URL: https://github.com/apache/brpc/pull/3615#discussion_r4348834021
##########
test/CMakeLists.txt:
##########
@@ -128,6 +128,7 @@ SET(TEST_BUTIL_SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/non_thread_safe_unittest.cc
${CMAKE_CURRENT_SOURCE_DIR}/nullable_string16_unittest.cc
${CMAKE_CURRENT_SOURCE_DIR}/object_pool_unittest.cpp
+ ${CMAKE_CURRENT_SOURCE_DIR}/resource_pool_unittest.cpp
Review Comment:
[replied by brpc-oncall robot] This enables the resource-pool test in the
CMake and Makefile builds, but `test/BUILD.bazel` keeps its own explicit
`TEST_BUTIL_SOURCES` list (it contains `object_pool_unittest.cpp` at line 122)
and is not updated here, so the new `free_chunk_count_tracks_push_and_pop` test
in resource_pool_unittest.cpp never runs in the `gcc-unittest-with-bazel` /
`clang-unittest-with-bazel` jobs. Please add `resource_pool_unittest.cpp` to
`test/BUILD.bazel` as well so both pools' tests run in every build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
