songgaoye opened a new pull request, #3648:
URL: https://github.com/apache/brpc/pull/3648
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
A thread key ID can be reused after deletion. During thread-exit cleanup, the
previous implementation selected the current destructor by key ID without
checking the generation stored alongside the thread-local value. As a result,
stale data from a deleted key could be passed to the destructor of a newer
key
that reused the same ID.
### What is changed and the side effects?
Changed:
- Validate the TLS entry generation (`seq`) against the current key
generation
before invoking its destructor during cleanup.
- Skip destructors for stale TLS entries.
- Add unit coverage for matching and mismatched key generations.
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
