songgaoye opened a new pull request, #3653:
URL: https://github.com/apache/brpc/pull/3653
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
`AsyncLogger::Log(const LogInfo&)` and `AsyncLogger::Log(LogInfo&&)`
duplicate
the same queue admission, shutdown, and synchronous fallback logic. Keeping
these paths separate makes future changes easier to diverge.
### What is changed and the side effects?
Changed:
- Consolidate the shared logging flow into an internal forwarding helper.
- Keep lvalue inputs copied and rvalue inputs moved only after a log request
is
successfully allocated.
- Preserve the existing synchronous fallback behavior when the logger is
full,
stopped, or allocation fails.
Side effects:
- No intended behavioral change.
- Performance effects:
No expected material performance change. The rvalue path still moves the
`LogInfo` into the queued request.
- Breaking backward compatibility:
No. This refactors private implementation details only.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
