wasphin opened a new pull request, #3665:
URL: https://github.com/apache/brpc/pull/3665
### What problem does this PR solve?
Problem Summary:
A Redis transaction can retain argument views across separate reads. The
connection currently clears its argument arena at the end of a read even
when a transaction handler is still active, so later reads can overwrite
those arguments before the transaction executes.
### What is changed and the side effects?
Changed:
- Retain the argument arena while a transaction handler is active.
- Document the argument-string lifetime during a transaction.
- Add a real connection regression with separate requests and repeated
transactions that retain argument views.
Side effects:
- Performance effects: Argument storage is retained until the transaction
completes; its memory use depends on the accumulated transaction data.
- Breaking backward compatibility: No API signature changes.
---
### Check List:
- [x] Changes compile locally.
- [x] Added focused regression coverage.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
