wasphin opened a new pull request, #3660: URL: https://github.com/apache/brpc/pull/3660
### What problem does this PR solve? Problem Summary: Numeric conversion of a bounded splitter field passes its start to C conversion routines without terminating it at the field end. A numeric suffix outside the field can affect conversion. ### What is changed and the side effects? Changed: - Convert a terminated copy of the current field in both splitter classes. - Document that conversions use only the current field. - Cover all six numeric conversion routines with a numeric suffix and a buffer without a trailing NUL. Side effects: - Performance effects: Copies the current field for numeric conversion. - Breaking backward compatibility: Numeric separators now delimit numeric fields in the same way as other separators. No API signature changes. --- ### Check List: - [x] Changes compile locally. - [x] Added focused regression coverage. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
