li-lizhe opened a new pull request, #3667: URL: https://github.com/apache/brpc/pull/3667
# What Issue #2804: the builtin-service samples in `docs/` point at `http://brpc.baidu.com:8765`, a host that has no record in public DNS, so those links are dead for anyone outside Baidu and the `curl` snippets cannot be pasted and run. This PR replaces the host with `localhost:8765` in the 27 documentation files that contain it (16 under `docs/cn`, 11 under `docs/en`), and rewords the two sentences in `builtin_service.md` (cn/en) that presented the page as a long-running example on the maintainers' machine, so they now tell readers to start `example/echo_c++` locally and open `http://localhost:8765`. That is the direction suggested in the issue thread. Only the host changes: paths, ports and the surrounding text are untouched. 57 of the 69 changed lines are a pure `brpc.baidu.com:8765` -> `localhost:8765` substitution (both `http://` links and the `curl host:port/...` snippets); the other two lines are the `builtin_service.md` sentences mentioned above. `localhost:8765` is the host:port the docs already use in their own runnable examples (e.g. the `curl` sample in `server.md`), and `example/echo_c++` serves its HTTP/builtin services on the port given by `-port`, so the samples stay runnable once the example is started locally. I kept the diff to a host substitution rather than switching to the example's default port. # What I verified, and what I did not - Verified: `brpc.baidu.com` has no A record (NXDOMAIN from two public resolvers over DNS-over-HTTPS) while `brpc.apache.org` resolves, so the old links are dead outside Baidu. - Verified in the diff: every changed line is either the pure host substitution or the two `builtin_service.md` sentences; no path, port or code block changed, and the files stay LF. - Not verified: I have not built brpc or run `example/echo_c++` in this environment, so I did not load these pages over `localhost:8765` myself. This PR also makes no claim about the other links in those files being alive. Ref #2804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
