songgaoye opened a new pull request, #3669: URL: https://github.com/apache/brpc/pull/3669
### What problem does this PR solve? Issue Number: resolve Problem Summary: `grpc-status` parsing accepts malformed values such as `"invalid"` and `"0junk"` as success because `strtol` errors and trailing characters are ignored. ### What is changed and the side effects? Changed: - Validate that `grpc-status` is nonempty, contains only digits, and is within the supported range (0–16). - Return `ERESPONSE` for invalid values. - Add tests covering malformed values, overflow, and all valid status codes. Side effects: - Performance effects: Minimal parsing overhead. - Breaking backward compatibility: Malformed status values previously accepted are now rejected. Valid responses are unaffected. --- --- ### Check List: - Please make sure your changes are compilable. - When providing us with a new feature, it is best to add related tests. - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
