Copilot commented on code in PR #3677: URL: https://github.com/apache/brpc/pull/3677#discussion_r4387365576
########## test/fuzzing/fuzz_streaming_seed_corpus/strm_short.bin: ########## @@ -0,0 +1 @@ +STR Review Comment: This seed contains only 3 bytes, but fuzz_streaming.cpp rejects inputs shorter than 5 bytes before calling ParseStreamingMessage. It therefore does not exercise the parser's incomplete-header handling. Regenerate it with at least 5 bytes, preserving the STRM prefix while remaining shorter than the 12-byte header. ########## test/fuzzing/fuzz_http_parser_seed_corpus/hp_post.bin: ########## @@ -0,0 +1,5 @@ +POST /up HTTP/1.1 Review Comment: The leading byte is `0x02`, which selects the non-CONNECT URL parser in `fuzz_http_parser.cpp`, not the HTTP request parser. Consequently, this POST request is passed to URL parsing instead of exercising request headers and body handling. Change the selector byte to `0x00` so the POST payload reaches the HTTP request parser. ########## test/fuzzing/fuzz_esp_seed_corpus/esp_short.bin: ########## @@ -0,0 +1 @@ + Review Comment: This seed contains only 3 bytes, but fuzz_esp.cpp rejects inputs shorter than 5 bytes before calling ParseEspMessage. It therefore does not exercise the parser's incomplete-header handling. Extend the seed to at least 5 bytes while keeping it shorter than EspHead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
