chenBright commented on code in PR #3651:
URL: https://github.com/apache/brpc/pull/3651#discussion_r4388502226
##########
src/bvar/detail/sampler.h:
##########
@@ -182,6 +182,7 @@ class CombinerSampleSource {
// sampling immune to R being destructed first.
template <typename R, typename T, typename Op, typename InvOp>
class ReducerSampler : public Sampler {
+ friend class LatencyRecorderTestPeer;
Review Comment:
The two friend class LatencyRecorderTestPeer; declarations are unnecessary.
The CMake, Makefile, and Bazel test builds already enable -fno-access-control,
so the test helper can access _sampler and _q directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
