BGQ99 commented on code in PR #3634:
URL: https://github.com/apache/brpc/pull/3634#discussion_r4396691497
##########
src/brpc/urma/urma_endpoint.cpp:
##########
@@ -1705,11 +1712,14 @@ int UrmaEndpoint::PollingModeInitialize(
}
void UrmaEndpoint::PollingModeRelease(bthread_tag_t tag) {
- if (!FLAGS_urma_use_polling || tag >= _poller_groups.size()) {
+ auto& poller_groups = PollerGroups();
+ if (!FLAGS_urma_use_polling || tag >= poller_groups.size()) {
Review Comment:
Fixed in 3ae8b745, now included in this PR. Shutdown no longer depends on
the polling flag. Both shutdown tests clear the flag before cleanup; they fail
against the previous implementation and pass with the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
