darion-yaphet commented on PR #3689: URL: https://github.com/apache/brpc/pull/3689#issuecomment-6516252151
Thanks for the follow-up. The new `join_races_with_destroy` test addresses my earlier concern: the waiter now signals only after the join path has already loaded `join_butex`, and destroy runs before `butex_wait`, so the race window is the reported. From the bthread id / butex side this LGTM. CI is green on this head; approving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
