hjwsm1989 commented on code in PR #3690:
URL: https://github.com/apache/brpc/pull/3690#discussion_r4422330529
##########
src/brpc/details/hpack.h:
##########
@@ -108,6 +108,14 @@ class HPacker : public Describable {
void Encode(butil::IOBufAppender* out, const Header& header)
{ return Encode(out, header, HPackOptions()); }
+ // Encode header as a literal without consulting or mutating the dynamic
+ // table (RFC 7541 section 6.2.2 / 6.2.3). Safe to use for trailers whose
+ // transmission may be deferred behind flow-controlled DATA frames while
+ // other streams continue to encode HEADERS on the same connection.
Review Comment:
Fixed in commit `62743640`: updated the doc comment on
`HPacker::EncodeWithoutDynamicTable` to clarify that it uses static-table
indexed representation when matched and literal representation otherwise,
without consulting or mutating the dynamic table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
